Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev.icinga.com #10617] Navigation is firing a massive amount of useless class_exists calls #2129

Closed
icinga-migration opened this issue Nov 12, 2015 · 4 comments
Closed

[dev.icinga.com #10617] Navigation is firing a massive amount of useless class_exists calls #2129

icinga-migration opened this issue Nov 12, 2015 · 4 comments

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10617

Created by tgelf on 2015-11-12 16:46:59 +00:00

Assignee: (none)
Status: New
Target Version: Backlog
Last Update: 2016-03-15 12:38:52 +00:00 (in Redmine)

This results in an unbelievable amount of needless stat calls in our class loaders. One call should be enough, configured renderer names MUST allow to figure out an eventual module name.
@icinga-migration
Copy link
Author

Updated by tgelf on 2015-11-13 11:00:30 +00:00

Hint: as unrelated components such as "badges" are/use NavigationItems, this affects many many views, not only the menu.

@icinga-migration
Copy link
Author

Updated by aklimov on 2015-12-10 13:52:59 +00:00

  • Status changed from New to Assigned
  • Assigned to set to aklimov

@icinga-migration
Copy link
Author

Updated by aklimov on 2015-12-10 14:37:25 +00:00

  • Status changed from Assigned to New
  • Assigned to deleted aklimov

@icinga-migration
Copy link
Author

Updated by elippmann on 2016-03-15 12:38:52 +00:00

  • Target Version set to Backlog

@icinga-migration icinga-migration added queue/important Blocks a release or needs immediate attention bug Something isn't working area/navigation Affects the navigation labels Jan 17, 2017
@icinga-migration icinga-migration added this to the Backlog milestone Jan 17, 2017
Al2Klimov added a commit that referenced this issue Jan 29, 2018
@Al2Klimov
Navigation: reduce amount of class_exists() calls
158e631 
refs #2129
@Al2Klimov Al2Klimov mentioned this issue Jan 29, 2018
Closed
Al2Klimov added a commit that referenced this issue Jan 30, 2018
@Al2Klimov
Prefix custom navigation items with their module names
b7c30ba 
refs #2129
@lippserd lippserd removed this from the Backlog milestone Apr 11, 2018
@nilmerg nilmerg removed queue/important Blocks a release or needs immediate attention labels May 9, 2019
@nilmerg nilmerg mentioned this issue Apr 11, 2022
Open
@nilmerg nilmerg removed bug Something isn't working area/navigation Affects the navigation labels Apr 11, 2022
@nilmerg nilmerg closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation: reduce amount of class_exists() calls Icinga/icingaweb2
3 participants
@lippserd @nilmerg @icinga-migration