Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement transiflex #3491

Closed
wants to merge 6 commits into from
Closed

WIP: Implement transiflex #3491

wants to merge 6 commits into from

Conversation

lazyfrosch
Copy link
Contributor

@lazyfrosch lazyfrosch commented Jun 27, 2018

I wanted to tryout Transifex for translations for Icinga Web and created an account:

https://www.transifex.com/icinga/icingaweb2

If anyone wants to help, join Transifex above and ping me for questions.

Actions:

  • Include and handle POT files
  • Upload current state to transifex
  • Use relative paths for files (no /usr/share/...)
  • Update local documentation

Handling in the future:

  • No more manual fiddling with po files
  • Update POT files when code changes (can be automated)
  • Work on the webserver
  • Pull PO files before and releases and compile them

Opinions?

@lazyfrosch lazyfrosch added the area/localization Affects the localization (i18n / l10n) label Jun 27, 2018
@lazyfrosch lazyfrosch self-assigned this Jun 27, 2018
@lazyfrosch lazyfrosch changed the title Implement transiflex WIP: Implement transiflex Apr 10, 2019
@nilmerg
Copy link
Member

nilmerg commented May 3, 2019

Had this much traction in the past months? Doesn't seem so to me, but I don't have an account.

If we're integrating this, we should consider guarding all translation calls against malicious strings (as I've already seen and used too many non-escaped $this->translate() calls) And having our internationalization this open makes this even more likely to be a serious problem.

@lazyfrosch
Copy link
Contributor Author

It was an experiment, but makes absolutely sense for use to have better translations...

There should be a way to check for escaped strings.

@nilmerg
Copy link
Member

nilmerg commented May 3, 2019

Of course it makes sense, I'm with you here. But if it's not used I don't see any advantage having it. Our previous translation maintainers did not have much interest here on Github. Adding another platform just to see the same result doesn't make any sense to me, unfortunately. So if there really was no activity at all in the past months on transiflex I'd see this experiment as failed.

@lazyfrosch
Copy link
Contributor Author

It is a way better UI than any local software and will allow non-technical people to help us translating.

We told nobody we even use Transifex, so why should anyone? It see it merely as a benefit that translations doesn't need to be done by developers.

@nilmerg
Copy link
Member

nilmerg commented May 3, 2019

We told nobody we even use Transifex, so why should anyone?

Then we should do so?

To be clear: I like the idea to have more recent/complete translations. Though what I don't like is the idea of a platform that is either inactive or requires a full time job to maintain. (And that's what it looks like now, previously I had the impression this is some kind of crowdsource platorm)

@nilmerg nilmerg added the stalled Blocked or not relevant yet label May 3, 2019
@lazyfrosch
Copy link
Contributor Author

This is up for adoption when someone wants to implement it

@lazyfrosch lazyfrosch removed their assignment Apr 7, 2020
@nilmerg
Copy link
Member

nilmerg commented May 4, 2020

Transifex is unfortunately not an option for us (anymore). Regarding their terms of use we're not open-source enough to make use of the free plan.

The automation however is still on track, though now in a separate project: https://github.com/Icinga/L10n

@nilmerg nilmerg closed this May 4, 2020
@nilmerg nilmerg deleted the translation/transifex branch May 4, 2020 07:42
@nilmerg nilmerg removed area/localization Affects the localization (i18n / l10n) stalled Blocked or not relevant yet labels May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants