Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/redesign about view #4496

Merged
merged 4 commits into from Feb 25, 2022
Merged

Feature/redesign about view #4496

merged 4 commits into from Feb 25, 2022

Conversation

flourish86
Copy link
Contributor

@flourish86 flourish86 commented Jul 28, 2021

Resolves #4328

@flourish86 flourish86 requested a review from nilmerg July 28, 2021 14:50
flourish86 added a commit that referenced this pull request Jul 29, 2021
@nilmerg
Copy link
Member

nilmerg commented Aug 2, 2021

Please reference the issue with resolves

@nilmerg nilmerg added this to In progress in v2.10.0 via automation Feb 16, 2022
@nilmerg nilmerg added area/ui Affects the user interface enhancement New feature or improvement labels Feb 16, 2022
v2.10.0 automation moved this from In progress to Ready Feb 25, 2022
@nilmerg nilmerg merged commit dee70b0 into master Feb 25, 2022
@nilmerg nilmerg deleted the feature/redesign-about-view branch February 25, 2022 11:33
v2.10.0 automation moved this from Ready to Done Feb 25, 2022
@flourish86
Copy link
Contributor Author

Thanks for taking over.

It's good how the width grows, with more content in the cells.

Can we make the "configure" buttons in @icinga-blue? See #4683

I also noticed another thing: If there's really long cell content the content width exceeds the viewport's width. Maybe this is not a problem in most cases, but it could be glitchy on narrower screen sizes.

Screen Shot 2022-02-28 at 09 32 15

@nilmerg
Copy link
Member

nilmerg commented Feb 28, 2022

I also noticed another thing

The commit id is of fixed length, that won't happen.

@flourish86
Copy link
Contributor Author

I also noticed another thing

The commit id is of fixed length, that won't happen.

Ok, seems to work in all screen widths, then.

@nilmerg nilmerg added this to the 2.10.0 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Affects the user interface cla/signed enhancement New feature or improvement
Projects
No open projects
v2.10.0
  
Done
Development

Successfully merging this pull request may close these issues.

Redesign System/About View
2 participants