Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Don't close the right column when submitting a form if not re… #4535

Closed

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented Sep 14, 2021

…quested

@cla-bot cla-bot bot added the cla/signed label Sep 14, 2021
@yhabteab yhabteab added area/javascript Affects the javascript framework bug Something isn't working labels Sep 14, 2021
@yhabteab yhabteab self-assigned this Sep 14, 2021
@yhabteab yhabteab force-pushed the bugfix/fix-do-not-close-right-column-if-not-requested branch from a1aacd3 to 8364cd8 Compare September 17, 2021 07:48
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. The intended effect is basically that of the recently introduced __CLOSE__ redirect rule. (e65ec19)

I think we should investigate if we can change all cases where redirects are expected to have that effect, to use __CLOSE__ instead. This isn't a problem for Icinga Web 2 itself and core modules. Other modules such as the Director though, may depend on this as well in which case we cannot remove it.

@yhabteab
Copy link
Member Author

I think we should investigate if we can change all cases where redirects are expected to have that effect, to use __CLOSE__ instead.

So how does this help us fixing our problem with the view mode switcher? After all, the right column will still be closed anyway.

@nilmerg
Copy link
Member

nilmerg commented Sep 20, 2021

So how does this help us fixing our problem with the view mode switcher?

The part of the JS that closes the right column and loads the redirect in the left one is removed then, because once everything uses __CLOSE__ it's obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Affects the javascript framework bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants