-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add canceled downtimes to the history, if they were started #5184
Conversation
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @Robnarok
|
i have signed the CLA |
@cla-bot check |
@gianlucapiccolo @mcodato This is the exact opposite of db9888b. Please have a look here and add your thoughts. |
i took another look at the implementation, and if i understand it correctly, the current behavior is:
removing the AND part like i did in the current PR, it would lead to
or a third solution could be if we would replace the AND with an OR (
(Edit: And prior to db9888b all of the 4 cases were displayed in the history) |
Hi @Robnarok, I see your point, the change we made was for another very annoying bug, let me do some internal tests and talk about it with my colleagues and I will let you know as soon as possible, thank you |
@Robnarok Thank you for your patience, the tests showed that your PR is fine for us, as it keeps the |
@Robnarok Please rebase with main, this should fix the actions |
fixes #5176