Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes::merge() ignores callbacks #63

Closed
nilmerg opened this issue Jun 1, 2022 · 0 comments · Fixed by #64
Closed

Attributes::merge() ignores callbacks #63

nilmerg opened this issue Jun 1, 2022 · 0 comments · Fixed by #64
Assignees
@nilmerg
Labels
bug Something isn't working
Milestone
v0.6.0

Comments

@nilmerg
Copy link
Member

nilmerg commented Jun 1, 2022

With this, only the foo attribute is registered:

$el = new HtmlElement('div', Attributes::create(['foo' => 'bar'])->registerAttributeCallback('bar', function () { return 'foo'; })); // <div foo=bar></div>

The result should be <div foo=bar bar=foo></div> however.
@nilmerg nilmerg added the bug Something isn't working label Jun 1, 2022
@nilmerg nilmerg added this to the v0.6.0 milestone Jun 1, 2022
@nilmerg nilmerg self-assigned this Jun 1, 2022
nilmerg added a commit that referenced this issue Jun 1, 2022
@nilmerg
Attributes: Respect callbacks in merge()
6162ef1 
fixes #63
@nilmerg nilmerg mentioned this issue Jun 1, 2022
Merged
nilmerg added a commit that referenced this issue Jun 1, 2022
@nilmerg
Attributes: Respect callbacks in merge()
2a2c007 
fixes #63
nilmerg added a commit that referenced this issue Jun 1, 2022
@nilmerg
Attributes: Respect callbacks in merge()
d86d8ed 
fixes #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilmerg nilmerg

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Attributes: Respect callbacks in merge() Icinga/ipl-html
1 participant
@nilmerg