SubmitButtonElement: Set the submit value by the value attribute
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
fix/submit-buttons-with-default-value-are-not-submitted-correctly
branch
2 times, most recently
from
5c10dc0
to
fa82938
Compare
lippserd
previously approved these changes
Mar 20, 2023
And also commit title and description 😆 |
|
Why? There's still a submit value that's not the value. |
We remove the |
|
😂 |
nilmerg
changed the title
value attributevalue attribute
|
Easy fix ;). |
Some forms still use `value` to define the submit value. It shouldn't make a difference to use it as submit value internally now, as the end result in HTML is the same.
nilmerg
force-pushed
the
fix/submit-buttons-with-default-value-are-not-submitted-correctly
branch
from
fa82938
to
e3659fa
Compare
lippserd
approved these changes
Mar 21, 2023
nilmerg
deleted the
fix/submit-buttons-with-default-value-are-not-submitted-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some forms still use
valueto define the submit value. It shouldn't make a difference to use it as submit value internally now, as the end result in HTML is the same.