Add HtmlDocument::insertBefore as well as HtmlDocument::insertAfter and emit an event upon assembly
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
feature/improve-html-document-class
branch
from
52cd3de
to
7cb8584
Compare
This provides an option to add html elements or attributes (especially in the case of decorators) to the `HtmlDocument` while it is being assembled.
raviks789
force-pushed
the
feature/improve-html-document-class
branch
4 times, most recently
from
2fcdf0a
to
8bf7b72
Compare
nilmerg
requested changes
Jun 2, 2023
The `HtmlDocument::class` should have an option to insert an Html element after or before a certain html element.
raviks789
force-pushed
the
feature/improve-html-document-class
branch
from
8bf7b72
to
2cf15bf
Compare
nilmerg
approved these changes
Jun 2, 2023
nilmerg
changed the title
HtmlDocument classHtmlDocument::insertBefore as well as HtmlDocument::insertAfter and emit an event upon assembly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref Icinga/icingadb-web#765