Fix empty claim though content is added in assemble #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
force-pushed
the
empty-but-not-assembled
branch
from
409f170
to
786777c
Compare
Before, isEmpty() would always return false even if there is content to be added in assemble(). Now ensureAssembled() is called before the empty check.
lippserd
force-pushed
the
empty-but-not-assembled
branch
from
786777c
to
7ad47c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, isEmpty() would always return false even if there is content to
be added in assemble(). Now ensureAssembled() is called before the empty
check.