New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PasswordElement class #57
Conversation
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @yhabteab
|
@cla-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Web 2's ResourceConfigForm
doesn't include the stored password in the DOM. I think we should do the same but natively in the element itself. I believe this should work, since ipl\Html\Form
can be (and in this case is) always being populated with the configuration:
- Don't use property
$value
ofipl\Html\FormElement\Password
to render thevalue
attribute, use a constant dummy password instead- Use an attribute callback for this
- Don't accept the dummy password as value for property
$value
(otherwise the real password is overridden and cannot be retrieved again bygetValue()
)
This should ensure that:
- A call to
setValue()
with the real password still stores it in property$value
(Done byFormElements::populate()
) - A call to
getValue()
still returns the real password, if one got set bysetValue()
(Done byFormElements::getValues()
) - The form doesn't render the real password in the DOM, but shows that a password is set
- The form accepts a new password
ea62e59
to
40869ad
Compare
cb1a960
to
0ffc5fd
Compare
11b02d6
to
18b5bc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's more, but I'd like to tackle that in person.
37f616b
to
14563d9
Compare
14563d9
to
e95c6f5
Compare
e95c6f5
to
ec26482
Compare
No description provided.