SelectElement: Override existing options in setOptions()
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
requested changes
Oct 4, 2022
sukhwinder33445
force-pushed
the
fix/setOptions-not-overwriting-existing-options
branch
from
d0a0e75
to
b47f3b5
Compare
`setOptions($opts)` call should not add $opts to existing options, but overwrite them completely.
sukhwinder33445
force-pushed
the
fix/setOptions-not-overwriting-existing-options
branch
from
b47f3b5
to
9edeb53
Compare
lippserd
changed the title
setOptions()setOptions()
lippserd
approved these changes
Oct 17, 2022
lippserd
changed the title
setOptions()setOptions()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectElement::setOptions($opts)call should not add $opts to existing options, but overwrite them completely.