Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: Allow overriding checked and unchecked values via attributes #69

Merged
merged 1 commit into from Oct 21, 2022

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla/signed label Aug 18, 2022
@sukhwinder33445 sukhwinder33445 force-pushed the fix/overwrite-checked-unchecked-value branch from 116c4be to f27778a Compare August 18, 2022 13:23
@sukhwinder33445 sukhwinder33445 self-assigned this Aug 22, 2022
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since overriding those values is already possible via setters the following commit message is more accurate:

Checkbox: Allow overriding checked and unchecked values via attributes

@sukhwinder33445 sukhwinder33445 force-pushed the fix/overwrite-checked-unchecked-value branch from f27778a to 3b0c5ed Compare October 20, 2022 14:26
@sukhwinder33445 sukhwinder33445 changed the title CheckboxElement: Make possible to overwrite default checked and unchecked value Checkbox: Allow overriding checked and unchecked values via attributes Oct 20, 2022
@lippserd lippserd added this to the v0.7.0 milestone Oct 21, 2022
@lippserd lippserd merged commit 949054c into master Oct 21, 2022
@lippserd lippserd deleted the fix/overwrite-checked-unchecked-value branch October 21, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants