Do not apply behaviors twice #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
requested changes
Apr 19, 2023
|
This boolean shows that the code flow is flawed and a proper solution would be not to perform any behaviors when the filter is moved to a subquery where it is processed again. |
yhabteab
force-pushed
the
do-not-apply-behaviours-twice
branch
from
7161383
to
d391360
Compare
|
Please use behaviors also in the PR title and description. |
yhabteab
force-pushed
the
do-not-apply-behaviours-twice
branch
from
d391360
to
80b4f29
Compare
yhabteab
force-pushed
the
do-not-apply-behaviours-twice
branch
from
3e95512
to
1d4ecd4
Compare
lippserd
previously approved these changes
Sep 4, 2023
nilmerg
requested changes
Sep 12, 2023
yhabteab
force-pushed
the
do-not-apply-behaviours-twice
branch
from
1d4ecd4
to
c15e1c0
Compare
nilmerg
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents now the subject behaviors from being applied for the same filter condition over again when it's wrapped into a subquery. This PR removes also the (now obsolete if condition) from the binary behaviour.
fixes #48
closes Icinga/icingaweb2-module-x509#174