SearchBar: Automatically submit columns if the label isn't changed #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save means something has changed, but it's not removed. This also poses a problem for the following change otherwise.
This relies on the fact that a suggestion can't be incorrect. Of course, this depends that the backend doesn't make incorrect suggestions 🙏
..in case the label hasn't changed. This again relies on an assumption: A label might be re-used in multiple places, but the data it describes should be the same. (e.g. host.display_name and service.display_name might use "Display Name" but it's still a string in the source.)
nilmerg
force-pushed
the
autosubmit-cols-if-the-label-isnt-changed
branch
from
e36e704
to
0cf514c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.