Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't quote null #433

Closed
rgevaert opened this issue Mar 1, 2018 · 2 comments
Closed

don't quote null #433

rgevaert opened this issue Mar 1, 2018 · 2 comments
Labels
bug
Milestone
v1.3.6

Comments

@rgevaert
Copy link
Contributor

rgevaert commented Mar 1, 2018

I noticed that null is always quoted. Which is something you would normally not want. Right?

I appreciate the way to make it possible to not automatically quote the full string, but shouldn't we add null to the excluded list?

https://github.com/Icinga/puppet-icinga2/blob/master/lib/puppet_x/icinga2/utils.rb#L89
@lbetz lbetz added the bug label Mar 2, 2018
@lbetz lbetz added this to the v1.3.6 milestone Mar 2, 2018
@lbetz lbetz closed this as completed in dd6023f Mar 2, 2018
@rgevaert
Copy link
Contributor Author

rgevaert commented Mar 2, 2018

Thanks Lennart!

@lbetz
Copy link
Contributor

lbetz commented Mar 2, 2018

you're welcome. That was simple. But I donno whenever we'll release 1.3.6.

bobapple pushed a commit that referenced this issue Apr 24, 2018
@lbetz @bobapple
fix #433 null does not quoted
7354616
n00by pushed a commit to n00by/puppet-icinga2 that referenced this issue Apr 26, 2018
@lbetz @n00by
fix voxpupuli#433 null does not quoted
44e4431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.3.6
Development

No branches or pull requests
2 participants
@rgevaert @lbetz