Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.0 #4

Merged
merged 1 commit into from
Mar 14, 2024
Merged

1.0.0 #4

merged 1 commit into from
Mar 14, 2024

Conversation

JacquesDIconica
Copy link
Contributor

@JacquesDIconica JacquesDIconica commented Mar 11, 2024 •
edited by freekvandeven
Loading

Closes #1

@freekvandeven
Copy link

@JacquesDIconica please squash the commit messages

@freekvandeven
Copy link

@Gorter-dev @JacquesDIconica maybe it should also be an option to provide the collectionnames so people can have multiple rbac instances in the same firestore database like we did with Safino.

@freekvandeven freekvandeven added the enhancement New feature or request label Mar 11, 2024
Gorter-dev
Gorter-dev requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Gorter-dev Gorter-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example can be removed, please improve README

README.md Outdated
@@ -0,0 +1,47 @@
# Flutter RBAC Service

Flutter RBAC Service is a package that enables to add a RBAC system to an excisting project. Currently only a Firebase Firestore datasource is provided, but a custom datasource can be constructed by implementing the `RbacDataInterface` and providing this to the `RbacService`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

README.md Outdated
To use this package, add flutter_rbac_services as a dependency in your pubspec.yaml file:

```
flutter_rbac_services:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

services should be service

README.md

```
RbacService(
FirebaseRbacDatasource(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing

README.md Outdated
),
```

From here any methods can be called from this service to set up and use RBAC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What method and how?

packages/flutter_rbac_services/lib/flutter_rbac_services.dart
@@ -1,4 +1 @@
library flutter_rbac_services;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library should be there?

packages/flutter_rbac_services/pubspec.yaml Outdated
url: https://github.com/Iconica-Development/flutter_rbac_service.git
path: packages/flutter_rbac_services_data_interface

path: ../flutter_rbac_services_data_interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before creating PR, should be reset to GIT

packages/flutter_rbac_services_data_interface/lib/flutter_rbac_services_data_interface.dart Outdated
library flutter_rbac_services_data_interface;

export 'src/rbac_data_interface.dart';
export 'src/models/account_data_model.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library should still be there

packages/flutter_rbac_services_firebase/lib/flutter_rbac_services_firebase.dart
@@ -1,3 +1 @@
library flutter_rbac_services_firebase;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library should still be there

packages/flutter_rbac_services_rest/test/flutter_rbac_services_rest_test.dart Outdated
import 'package:flutter_rbac_services_rest/flutter_rbac_services_rest.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed right?

packages/flutter_rbac_services_rest/lib/flutter_rbac_services_rest.dart Outdated
@@ -1,5 +1,3 @@
library flutter_rbac_services_rest;

/// A Calculator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

@Gorter-dev Gorter-dev merged commit e9e56e2 into master Mar 14, 2024
1 check passed
@Gorter-dev Gorter-dev deleted the 1.0.0 branch March 14, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekvandeven freekvandeven freekvandeven left review comments

@Gorter-dev Gorter-dev Gorter-dev approved these changes

@FlutterJoey FlutterJoey Awaiting requested review from FlutterJoey

Assignees

@JacquesDIconica JacquesDIconica

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FInish the RBAC service
3 participants
@JacquesDIconica @freekvandeven @Gorter-dev