Button design improvement for issue Dialog #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naushad-madakiya
changed the title
naushad-madakiya
changed the title
naushad-madakiya
suggested changes
Oct 7, 2017
| android:layout_toLeftOf="@id/ok" | ||
| android:background="@drawable/border" | ||
| android:elevation="5dp" | ||
| android:text="EDIT" /> |
There was a problem hiding this comment.
Use the existing strings from the string resource.
| android:layout_marginTop="30dp" | ||
| android:background="@drawable/border" | ||
| android:elevation="5dp" | ||
| android:text="OK" /> |
There was a problem hiding this comment.
Use text from the string resource.
| android:layout_marginTop="30dp" | ||
| android:background="@drawable/border" | ||
| android:elevation="5dp" | ||
| android:text="DELETE" /> |
There was a problem hiding this comment.
use text from the string resource
|
Done @naushad-madakiya |
|
@naushad-madakiya @manparvesh Could you kindly act on this? |
naushad-madakiya
approved these changes
Oct 10, 2017
naushad-madakiya
suggested changes
Oct 15, 2017
| final AlertDialog.Builder builder = new AlertDialog.Builder(MainActivity.getInstance()); | ||
| View view = LayoutInflater.from(MainActivity.getInstance()).inflate(R.layout.custom_dialog, null); | ||
| builder.setView(view); | ||
| Button editBitton = (Button) view.findViewById(R.id.edit); |
There was a problem hiding this comment.
Fix typo with editBitton
| .setNegativeButtonColorRes(R.color.md_pink_a200) | ||
| .show(); | ||
|
|
||
| final AlertDialog.Builder builder = new AlertDialog.Builder(MainActivity.getInstance()); |
There was a problem hiding this comment.
AlertDialog.Builderis not required to make final- Should use better-naming convention i.e. editDialogBuilder instead of builder only.
build.gradle
Outdated
| @@ -8,7 +8,7 @@ buildscript { | |||
| } | |||
| } | |||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:2.3.1' | |||
| classpath 'com.android.tools.build:gradle:2.3.3' | |||
There was a problem hiding this comment.
Should not change configuration if not required.
|
@djubreel can you remove the autogenerated files from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the dialog buttons in the dialog look like buttons and not links
Changes proposed in this pull request:
Implemented a custom alertdialog with view as
custom_dialog.xmlandborder.xmlfor button borders. Increase gradle version to2.3.3from2.3.1