Fix for issue Neumorphic button issue #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issues/169
josiahsrc
suggested changes
Sep 18, 2020
lib/src/widget/button.dart
Outdated
| @@ -177,7 +177,7 @@ class _NeumorphicButtonState extends State<NeumorphicButton> { | |||
|
|
|||
| Widget _build(BuildContext context) { | |||
| final appBarPresent = NeumorphicAppBarTheme.of(context) != null; | |||
| final appBarTheme = NeumorphicTheme.of(context).current.appBarTheme; | |||
| final appBarTheme = NeumorphicTheme.of(context)?.current?.appBarTheme; | |||
There was a problem hiding this comment.
I'd suggest doing this instead:
final appBarTheme = NeumorphicTheme.currentTheme(context).appBarTheme;
Reason being that the NeumorphicTheme.of(context)?.current?.appBarTheme; still has a possibility of returning null (which will still throw a null reference exception). NeumorphicTheme.currentTheme is guaranteed to not return null.
There was a problem hiding this comment.
I have done the required changes @josiahsrc
|
Can we please merge this? I need it in my production code. |
|
@ashank96 If you need it right now, you can create a dependency in your Source: https://flutter.dev/docs/development/packages-and-plugins/using-packages |
|
thanks, sorry for the delay, I publish it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue
The issue is because of the following line:
final appBarTheme = NeumorphicTheme.of(context).current.appBarTheme;This should work, if I am using NeumorphicApp as the parent widget, which initialises NeumorphicTheme() but I do not want to use NeumorphicApp as my parent widget, hence NeumorphicTheme.of(context) will always be null.