Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional input/output for node #62

Merged
merged 1 commit into from Sep 6, 2021
Merged

Conversation

ishiy1993
Copy link
Contributor

When the name is empty, treat it as optional input/output.

https://github.com/onnx/onnx/blob/master/docs/IR.md#optional-inputs-and-outputs

@ishiy1993 ishiy1993 mentioned this pull request Sep 6, 2021
Copy link

@koiking213 koiking213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishiy1993 ishiy1993 merged commit 7790994 into master Sep 6, 2021
@ishiy1993 ishiy1993 deleted the fix-optional-input-output branch September 6, 2021 10:27
@ishiy1993 ishiy1993 mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants