Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

enhance http calls to OP to check content-type on response for json #488

Closed
brockallen opened this issue Jan 18, 2018 · 7 comments
Closed
Assignees
Milestone

Comments

@brockallen
Copy link
Member

No description provided.

@brockallen brockallen added this to the 1.5.0 milestone Jan 22, 2018
@brockallen brockallen self-assigned this Jan 22, 2018
@brockallen brockallen changed the title enhance http calls to OP with some accept/content-type work enhance http calls to OP to check content-type on response for json May 5, 2018
@brockallen
Copy link
Member Author

done

@ericmorand-emakina
Copy link

@brockallen, is this needed because OpenID specs enforce this? Our SSO provider send application/jwk-set+json;charset=UTF-8.

@brockallen
Copy link
Member Author

it was used to detect when the OP had an error and was showing html pages

@ericmorand-emakina
Copy link

But then application/jwk-set+json responses throw exceptions. I'm wondering if our SSO provider is at fault there. Do you think I should open an issue here? application/jwk-set+json looks like a valid content type:

https://tools.ietf.org/html/rfc7517

@brockallen
Copy link
Member Author

which token server do you use?

@ericmorand-emakina
Copy link

Connect2id

@longsleep
Copy link
Contributor

This change is wrong - oidc-client should accept application/jwk-set+json response types which is the right content type for JSON web keys. This makes oidc-client-js essentially non-functional for OIDC providers which properly set the content type for jwk endpoints.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants