Remove babel-polyfill from peerDependencies

[fttriquet]

#Can babel-polyfill be removed from peerDependencies ?

In our app we do not need that dependency to use oidc client, but removing it from our dependencies will cause the unmet peer dependency warning.

cc @davinkevin

[brockallen]

Yes, I was thinking of how to build this with two versions -- one with the polyfill and one without. I'll see what I can do.

[brockallen]

So this is the PR that added it: #166

So should we have it or not? // @kristofdegrave

[brockallen]

@fttriquet any update?

[fttriquet]

Sorry for the delay, nothing more on my side, having a specific version without that dependency would do the trick for us.

[brockallen]

As I see it, you might need this peerDependency... it depends on what and how you deploy your app.

[davinkevin]

It could be an optional dependency ?

[brockallen]

Yes, depending on how you use/package/depend on oidc-client. If you use it as a ES6 module or use the UMD in ~/lib and run in an older browser then you need to have the polyfill in there somehow. That was the point of the PR from @kristofdegrave, I believe.

[fttriquet]

I see what you mean, but it seems to be quite a specific case their, I would say it's up to the client to manage that part ? Kevin's proposition would solve this (without having to do several builds), and add en entry in the readme about polyfill.

[davinkevin]

@brockallen The PR of @kristofdegrave add it to peerDependencies instead of optionaldependencies (docs)

Putting it inside this here should solve the original problem of @fttriquet and won't break because peerDependencies are not installed since NPM 3 (& Yarn)

[brockallen]

Ah I wasn't aware of the dedicated optional dependency config (which explains why I ignored the mention of it above). That sounds like the right place. Thanks

[brockallen]

Done, thanks for helping me thru that!

[davinkevin]

Thx 👍

[fttriquet]

Great news, thank you