Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Support for client_secret_basic #892

Open
orsolli opened this issue Jul 9, 2019 · 5 comments
Open

Support for client_secret_basic #892

orsolli opened this issue Jul 9, 2019 · 5 comments

Comments

@orsolli
Copy link

orsolli commented Jul 9, 2019

Related to Issue #843

This library uses client_secret_post which puts the client_id and client_secret in the body.

You should support client_secret_basic where client_id and client_secret is base64 encoded in the Authorization header in accordance to to OAuth2.0 and OpenID Connect specifications.

The OAuth 2.0 Authorization Framework - 2.3.1. Client Authentication
OpenID Connect Core 1.0 - 9. Client Authentication

@AshUK
Copy link

AshUK commented Jun 4, 2020

My preference for this would be a property named token_endpoint_auth_method given to the UserManager configuration. Its worth mentioning there are other auth methods too:

https://www.iana.org/assignments/oauth-parameters/oauth-parameters.xhtml#token-endpoint-auth-method

  • none
  • client secret basic
  • client secret jwt
  • client secret post
  • private key jwt

@damiandragowski
Copy link

Hi,
When support for client_secret_post will be released ?

@thorstenfleischmann
Copy link

Would be good to have support for basic auth since using post is not recommended.

https://tools.ietf.org/html/rfc6749#section-2.3.1

Including the client credentials in the request-body using the two
parameters is NOT RECOMMENDED and SHOULD be limited to clients unable
to directly utilize the HTTP Basic authentication scheme (or other
password-based HTTP authentication schemes).

@bbialas
Copy link

bbialas commented Nov 17, 2020

+1

Any news on when it could be added?

@Blamoh
Copy link

Blamoh commented Dec 21, 2020

Hi,

Any news ?

brockallen added a commit that referenced this issue Jan 28, 2021
Add client_secret_basic auth exchangeCode Method. #892
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

7 participants