This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
Make oidc-client ReactNative-friendly #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if saw my code comment? I asked: should this be keys.length? there's a for loop that it looks like it's missing. |
|
No I didn't see any comment, but you're correct, .length was certainly missing. |
|
Is there an ETA regarding when this branch will be merged ? I believe this'll fix errors for me as well |
|
@brockallen any idea on a timeline for merging this one into a new release? |
|
Why would you use that from a React Native app - native apps don't use implicit flow - they follow |
|
That'd work too, was just going off of this pull request. |
|
Sorry for the delay. I tested this and looks good to merge. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes makes this lib RN-friendly, meaning that it is possible to require it from a RN app (#306). The app must still create navigators that suits RN of course.
One change is that the buffer lib is not included in the minified file(s).
The other change is to not use 'for (.. of ..)' constructs since that seems to be troublesome for JavaScriptCore (facebook/react-native#4587) .