Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Improved typings for typescript #481

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Improved typings for typescript #481

merged 2 commits into from
Jan 23, 2018

Conversation

rstaib
Copy link
Contributor

@rstaib rstaib commented Jan 10, 2018 •
edited

  • Improved typescript typings
  • Exported User to be able to create my own instance
  • Checked that all tests passed
  • Increased version to 1.4.2

@brockallen
Copy link
Member

extraQueryParams was removed -- was that intentional?

@brockallen brockallen added this to the 1.5.0 milestone Jan 22, 2018
@rstaib
Copy link
Contributor Author

rstaib commented Jan 23, 2018

No, I guess it was a mistake, because it makes no sense to me either. I have re-added the extraQueryParams field and changed the type from any to {}. Also added readonly modifier to most of the OidcClientSettings and UserManagerSettings fields.

@brockallen
Copy link
Member

Nice, thanks!

@brockallen brockallen merged commit d7b4f60 into IdentityModel:dev Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rstaib @brockallen