Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Optional config in OidcClient. #7

Closed

Conversation

magnushenning
Copy link

Alternative pull request to solve issue #5.

This allows for the developer to use:

var settings = { response_type: 'id_token token', ...};
var config = { responseType: 'text' };
var client = new OidcClient(settings, config);

I think this is a better solution than the other pull request. Let me know if you want any changes, e.g:

  • maybe 'config' should be named 'options'
  • maybe config.responseType should be config.httpRequest.responseType.

Magnus H.

Store optional config in this._config
Parse this._config to _httpRequest.getJSON(url, this._config)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants