This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
Fully qualify import paths #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to this; would also like to know if there will be adoption of |
|
Hey @brockallen -- is this change set something you might consider? Thanks |
|
@charricknflx this is a backwards compat change? |
|
Yes. the change only modifies import paths and export syntax. Which the current build handles without issue. |
|
Merged, thanks |
|
1.7.0-beta.1 has been published to npm, please test and see if it's working for you. |
|
@brockallen Tested locally and works as expected. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding the file extension to every imported module in oidc-client-js source and updating the footer of jsrsasign, native ES6 imports will work properly in a browser without a build pipeline. This will have no impact on the current build process.
Working example: