Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and improvements for satosa-saml-metadata #429

Merged
merged 2 commits into from Jun 11, 2023
Merged

Fixes and improvements for satosa-saml-metadata #429

merged 2 commits into from Jun 11, 2023

Commits on Mar 21, 2023

  1. fix: metadata_creation: for SAML backend, use sp.config to render met… 

    …adata

... because SAMLBackend modifies the config (adding encryption_keypairs to config)
and this modified config is stored under sp.config.

Otherwise, metadata created via the metadata-creation scripts (satosa-saml-metadata)
would be missing encryption keys (KeyDescriptor use="encryption").
    @vladimir-mencl-eresearch
    vladimir-mencl-eresearch committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    00c0d05 View commit details
    Browse the repository at this point in the history

  2. new: satosa-saml-metadata: make signing optional 

    Allow skipping signing with --no-sign - and in that case, do not require key+cert.

Default to signing enabled (keep existing behaviour).

Mark key and cert args as optional in Click and instead check them explicitly
when signing is enabled.

Add new method create_entity_descriptor_metadata as counterpart
to create_signed_entity_descriptor to also apply `valid` option
to EntityDescriptor but avoid signing.
    @vladimir-mencl-eresearch
    vladimir-mencl-eresearch committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    18667fc View commit details
    Browse the repository at this point in the history