Skip to content

Refactoring ToDo, Wishes, Suggestions

Ivan Kanakarakis edited this page Jul 19, 2020 · 4 revisions

Naming

  • We currently use the modules plugins/backend/saml2.py and plugins/frontend/saml2.py. We should rename them to saml2_be.py and saml2_fe.py to clarify in the logfile whether a message was issued by pysaml2 or satosa.

  • Satosa knows 2 relay_states, one for the frontend and one for the backend. These should be named accordingly in State.state_dict to be self-documenting when looking at the data, or merged into a single relay_state. IIUC satosa only checks that relay_state is returned unchanged.

  • InternalData: We should find a non-generic name for this data structure; "internal data" could be anything.