Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo now displayed on "/role/ds.s" search for ra21 template #166

Conversation

peppelinux
Copy link
Member

Hi with this PR now I can get displayed the logo of the entities during ds-search, as follow:

Selezione_543

This is also related to #150 and hopefully fixes it.
I'm sure that this is a work in progress in other branches but they are too much that I preferred this pratical way. Consider me in listen for any ideas and suggestions that would come to this result

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@leifj
Copy link
Contributor

leifj commented Mar 30, 2021

This is a prefectly valid PR but I'm not going to merge it anyway since the code it refers to is about to be deprecated and has already been moved out into theidentityselector/thiss-js

@leifj leifj closed this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants