Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 compatibilty #62

Merged
merged 9 commits into from Jan 17, 2019
Merged

Python 3 compatibilty #62

merged 9 commits into from Jan 17, 2019

Conversation

johanlundberg
Copy link
Contributor

@johanlundberg johanlundberg commented Jan 15, 2019 •
edited by c00kiemon5ter

Thanks to @hfalcic for the previous PR (#17) for Python 3 support, which I based this PR on.

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

The previous effort #17 is now outdated.

  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@coveralls
Copy link

Coverage Status

Coverage increased (+7.06%) to 79.726% when pulling 1ec6b05 on SUNET:fix_python3 into e0cd024 on IdentityPython:master.

fredrikt
fredrikt approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@fredrikt fredrikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leifj leifj merged commit d724f8d into IdentityPython:master Jan 17, 2019
leifj
leifj reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@leifj leifj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - I merged and will do a PR containing some log updates from my own branch presently

@johanlundberg johanlundberg mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leifj leifj leifj left review comments

@fredrikt fredrikt fredrikt approved these changes

@c00kiemon5ter c00kiemon5ter Awaiting requested review from c00kiemon5ter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johanlundberg @coveralls @fredrikt @leifj