Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

SigninMessageThreshold as an option #1044

Merged
merged 6 commits into from
Mar 11, 2015

Conversation

loctanvo
Copy link
Contributor

@loctanvo loctanvo commented Mar 9, 2015

Summary:

Additional comments:

  • CLA is signed
  • The default threshold value is 5. Ealier, this resulted in 6 SignInMessage cookies. Now, if 5 is defined, 5 cookies are kept. Simply because it was difficult to explain in unit test the off by 1 behavior.
  • There is some (intentionally?) duplicated code in the test project. For unit testing, IdSvrHostTestBase.WriteMessageToCookie<T> and Thinktecture.IdentityServer.Tests.Endpoints.Setup.Extensions.cs were modified. There are similar functionalities in the Conformance ns that are not touched. Didn't want to make the PR too messy.

brockallen added a commit that referenced this pull request Mar 11, 2015
@brockallen brockallen merged commit 333ecf1 into IdentityServer:dev Mar 11, 2015
@brockallen
Copy link
Member

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants