This repository has been archived by the owner on Mar 20, 2019. It is now read-only.
Make ProfileService.IsActive respect user lockouts #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it make sense to keep it the way it is: currently it leaves it up to resource server to decide whether user is authorized (imo lockout comes under authz). The current way you can get feedback when you are locked out... Not sure. |
|
This is not a good idea, IMO. If I brute force your account on the login page, this will cause IdentityServer to stop issuing tokens to all your user's legit clients. |
|
Excellent point! This can be closed and rejected thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is desirable or not.
Thoughts?