Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Disable default caching for discovery #1132

Closed
brockallen opened this issue May 4, 2017 · 4 comments
Closed

Disable default caching for discovery #1132

brockallen opened this issue May 4, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@brockallen
Copy link
Member

No description provided.

@brockallen brockallen added the bug label May 4, 2017
@brockallen brockallen added this to the 1.5.1 milestone May 4, 2017
@brockallen brockallen self-assigned this May 4, 2017
@brockallen
Copy link
Member Author

fixed

@laurynasr
Copy link

Why was this change done?
At least the doc comments still say that it defaults to one hour:

/// Sets the maxage value of the cache control header (in seconds) of the HTTP response. This gives clients a hint how often they should refresh their cached copy of the discovery document (defaults to one hour).

@brockallen
Copy link
Member Author

The change was done because once you go to production you are expected to choose these values (not us). Also, if you don't know about the value and it's set by default then you might have unexpected behavior in prod.

@lock
Copy link

lock bot commented Jan 14, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants