Parameters twisted for GetConsentKey

[whymatter]

Hey guys,

on my way though the code which writes into the PersistedGrants table I found these bits of code which seem to be wrong.

The first parameter of the GetConsentKey function is the subjectId and the second one is the clientId. But all invocations of this method pass clientId as first and subjectId as second parameter. This seems wrong to me.

I guess this is not evil but at least not really clean.

IdentityServer4/src/IdentityServer4/Stores/Default/DefaultUserConsentStore.cs

Lines 34 to 48 in 74827bc

	private string GetConsentKey(string subjectId, string clientId)
	{
	return subjectId + "|" + clientId;
	}
	/// <summary>
	/// Stores the user consent asynchronous.
	/// </summary>
	/// <param name="consent">The consent.</param>
	/// <returns></returns>
	public Task StoreUserConsentAsync(Consent consent)
	{
	var key = GetConsentKey(consent.ClientId, consent.SubjectId);
	return StoreItemAsync(key, consent, consent.ClientId, consent.SubjectId, consent.CreationTime, consent.Expiration);
	}

[brockallen]

Merged and fixed, thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.