Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Error Response with invalid redirection URI on authorize endpoint #4145

Closed
user1336 opened this issue Mar 4, 2020 · 5 comments
Closed

Error Response with invalid redirection URI on authorize endpoint #4145

user1336 opened this issue Mar 4, 2020 · 5 comments
Labels
Milestone

Comments

@user1336
Copy link
Contributor

user1336 commented Mar 4, 2020

Same as #4075 but on the Authorize endpoint:

In the OAuth authorization_code flow, when validating the redirect_uri on the authorize endpoint, why do we return an unauthorized_client when the redirect_uri is invalid.

Shouldn't this be an invalid_request according to the spec:

invalid_request
The request is missing a required parameter, includes an
invalid parameter value, includes a parameter more than
once, or is otherwise malformed.
https://tools.ietf.org/html/rfc6749#section-4.1.2.1

Parameter is invalid, unauthorized_client says something about the method the client uses to request an authorization_code.

If you agree I can do the work on this.

@stale
Copy link

stale bot commented Mar 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Questions are community supported only and the authors/maintainers may or may not have time to reply. If you or your company would like commercial support, please see here for more information.

@brockallen
Copy link
Member

We didn't see a PR for the authorize EP as well, so we just made the fix. Thanks.

@user1336
Copy link
Contributor Author

If you'd agreed, I would have made one.

Thanks anyway, this helps a lot!

@brockallen
Copy link
Member

No worries. Thanks

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants