Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Bug Fix #4036 - missing crv value when passing JsonWebKey to AddSigni… #4037

Merged
merged 3 commits into from
Feb 3, 2020
Merged

Conversation

brunobritodev
Copy link
Contributor

@brunobritodev brunobritodev commented Feb 3, 2020

What issue does this PR address?
Minor bug fix related at #4036

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • [X ] The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:
I've provided only integration tests and some unit tests as well.

@dnfclas
Copy link

dnfclas commented Feb 3, 2020

CLA assistant check
All CLA requirements met.

@leastprivilege leastprivilege self-assigned this Feb 3, 2020
@leastprivilege leastprivilege added this to the 3.1.1 milestone Feb 3, 2020
@leastprivilege leastprivilege merged commit 4ef0886 into IdentityServer:master Feb 3, 2020
@leastprivilege
Copy link
Member

Hi,

merged to master. If you want that fix to appear in 3.1.1, please do a PR against

https://github.com/IdentityServer/IdentityServer4/tree/releases/3.1.x

@leastprivilege
Copy link
Member

thanks!

@leastprivilege leastprivilege modified the milestones: 3.1.1, 4.0 Feb 3, 2020
@brunobritodev brunobritodev mentioned this pull request Feb 3, 2020
2 tasks
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants