This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Update to Message<TModel> to enable deserialization in .NET 5.0-rc1 #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
THanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
#4912 - System.Text.Json deserialization fails in .NET5 RC1
Does this PR introduce a breaking change?
It shouldn't. The only change is that the parameterless constructor for IdentityServer4.Models.Message has been made public as the System.Text.Json.JsonSerializer requires a public parameterless constructor
Please check if the PR fulfills these requirements
Other information:
A unit test has been added for IdentityServer4.ObjectSerializer. However, the test wouldn't fail with an internal constructor using netcoreapp3.1. Having that said, it would ensure it works when moving to net5.0.