Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Into Account Non-integer Offsets #109

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

Dheatly23
Copy link
Contributor

This should fix non-integer margin that #98 broke. I put provisions for future y-offset too.

@Dheatly23
Copy link
Contributor Author

After thinking about it, it maybe better to put extra data as keyword argument instead of making it longer and longer. Will implement it later.

Ensure future-proofing for extra data with kwarg.
@IdreesInc
Copy link
Owner

IdreesInc commented Feb 12, 2023

Screen Shot 2023-02-12 at 4 16 11 PM

Thanks for your work on this once again! Seeing a weird issue in the generated .otf file that isn't there with the .ttf where some characters with holes like 8, O, and o are being filled in. Not sure why this is or if the previous version had this problem too

EDIT: Can confirm that the previous version also has this issue, weird that it only shows up for otf files. Will make another issue for this: #110

@IdreesInc
Copy link
Owner

Can confirm that this work fixes the margin problem, thanks again for all the work you have put in to making the polygon generation possible! Will wait to release the next version until we can figure out why the above issue is happening.

@IdreesInc IdreesInc merged commit f2b5d12 into IdreesInc:main Feb 12, 2023
@Dheatly23 Dheatly23 deleted the non-integer-margin branch February 13, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants