Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added continuous ligatures #116

Merged
merged 11 commits into from
Jun 10, 2023
Merged

Conversation

Ciubix8513
Copy link
Contributor

@Ciubix8513 Ciubix8513 commented Mar 7, 2023

A PR for #115
These ligatures make various cli tools look so much nicer:
Cargo:
image
image
Pacman:
image
image

I was thinking of adding another type, 2 headed ligatures, so that things like <=> can be expanded, but i'm not sure if there's any point in that.

But there's also currently a bug where shorter ligatures are slightly smaller:
image
I think there might be something wrong with the generateImage function.

@Ciubix8513
Copy link
Contributor Author

I just fixed the ligatures being smaller bug, so now everything should work as intended

@IdreesInc
Copy link
Owner

Interesting, this is definitely something I've been meaning to look into. Thank you for working on this, will hopefully be able to review it properly in the next couple of days!
In the meantime, heads up that "continuous" is missing the "u" at the end in the file name so that will need to be fixed before merge

@Ciubix8513 Ciubix8513 changed the title Added continuos ligatures Added continuous ligatures May 28, 2023
@IdreesInc
Copy link
Owner

Thanks for your patience with this review, life got in the way.
This looks great, I really appreciate the work your put into this! I am going to make some minor style changes and test its compatibility with beta build before merging into main, but it works like a charm on my machine. Thanks again!

@IdreesInc IdreesInc changed the base branch from main to v3 June 10, 2023 17:14
@IdreesInc IdreesInc merged commit 7da29e1 into IdreesInc:v3 Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants