-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support For Cyrillic Letters #36
Conversation
You are probably right. Originally, I didn't want to change the font too much and used existing glyphs like |
It really does look weird with 5px. |
Thank you for the tremendous amount of work you've put into adding all of these characters, as well as for including screenshots in the PR so that it is easy to compare against the game. Everything looks good to me and I feel like you've done the most you can given the constraints of the monospacing. I'll merge this in to a separate branch first so that I can deal with conflicts from other PRs before merging it into main. |
As suggested in #4 I have added support for cyrillic characters. This addition contains 96 glyphs ranging from U+0400 to U+045f. To match the existing space constraints (due to monospace) some characters, such as
Ж
orФ
, had to be redesigned a little.Regardless, it was not possible to 'squeeze' every character this way, which is why a few characters have missing spacing. This is the case forЮ
,for instance.Feel free to reach out if you find any further issues.
(note that they are not monospace)
This is what it looks like in VSCode (outdated):