Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing generation feature request : Having a crease threshold setting #3668

Open
Gorgious56 opened this issue Aug 30, 2023 · 3 comments
Open

Comments

@Gorgious56
Copy link
Contributor

Following #3158

How feasible is it to have a setting or a threshold for dissolving edges in almost-coplanar faces ?
Here's a model export from pure ifcopenshell

image

And here's the same with the prj addon for Blender which is powered by Blender's line art modifier.

image

Both renders are by no means perfect, but Blender's line art modifier allows for some granularity in what edges should or shouldn't be drawn. I also wonder about intersections between objects, which are not strictly speaking derived from actual geometry.

Animation3

I model existing buildings so slabs, walls etc. are never pefectly coplanar, so ideally a threshold of coplanarity to dissolve edges would be extremely useful in drawing renderings.

@Moult
Copy link
Contributor

Moult commented Aug 31, 2023

The intersection lines are probably the same problem reported here: #3561

@Moult
Copy link
Contributor

Moult commented Apr 9, 2024

Ping @aothms now that there is a set unify inputs, is there a possibility of adjusting the angular tolerance?

@aothms
Copy link
Member

aothms commented Apr 23, 2024

now that there is a set unify inputs, is there a possibility of adjusting the angular tolerance?

In theory yes, you can experiment with it in a local build. Both hard coded in a different place:

[0] https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/serializers/SvgSerializer.cpp#L708C57-L708C62
[1] https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/ifcgeom_schema_agnostic/boolean_utils.cpp#L586

But I don't think this can be set arbitrarily high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants