This repository has been archived by the owner on Dec 17, 2019. It is now read-only.
Update jquery.popconfirm.js #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added onYes and onNo options to run a specific callback when buttons are clicked.
Work around to stop failing if e is not given to click event. Stops issue where the following is thrown: ```Cannot read property 'preventDefault' of undefined```
|
Ok for the merge :) But what do you think about putting contributors on the package.json ? If you're on it, i think all contribs should be here to. Maybe it will be a hudge work to sync the files on each contrib and do it twice as we have to do the same thing on |
|
I think this is a very useful addition. When will you merge this into master? |
|
The contributors problem was not resolved, and i should look after a more clearer documentation if we add this feature. Or the usage will be less understandable |
|
Not sure why I put my own name in that authors field. I've removed it now as it's not necessary. Can we merge this. I'd like to remove my fork. |
|
Removing my fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added onYes and onNo options to run a specific callback when buttons are clicked.