Skip to content

Commit

Permalink
Remove the round-robin list for third-party additions
Browse files Browse the repository at this point in the history
Instead, require an email to opensource-licensing@ again until we
figured out the new process.

R=jam@chromium.org

Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
Reviewed-on: https://chromium-review.googlesource.com/c/1275846
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599122}
  • Loading branch information
jeisinger authored and Commit Bot committed Oct 12, 2018
1 parent 6c30443 commit 13767a5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
9 changes: 4 additions & 5 deletions docs/adding_to_third_party.md
Expand Up @@ -127,12 +127,11 @@ can email one of the people in third_party/OWNERS for help.
When adding a new package that could potentially carry security risk, make
sure to highlight risk to security@chromium.org. You may be asked to add
a README.security or, in dangerous cases, README.SECURITY.URGENTLY file.
* Add chromium-third-party@google.com as a reviewer on your change. This
will trigger an automatic round-robin assignment of the review to an
appropriate reviewer. This list does not receive or deliver email, so only
use it as a reviewer, not for other communication.
* Get licensing approval. Email opensource-licensing@google.com with relevant
details and a link to the CL.

Please send separate emails to the eng review and security lists.
Please send separate emails to the eng review, opensource licensing, and
security lists.

Subsequent changes don't require third-party-owners approval; you can modify the
code as much as you want. When you update code, be mindful of security-related
Expand Down
4 changes: 0 additions & 4 deletions third_party/OWNERS
Expand Up @@ -14,10 +14,6 @@
# Eng reviewer
file://ENG_REVIEW_OWNERS

# Automatic round-robin assignment of reviewer for third-party licenses.
# No one receives email to this list, just use it as a reviewer.
chromium-third-party@google.com

thakis@chromium.org

per-file .gitignore=*

0 comments on commit 13767a5

Please sign in to comment.