Reset Cursor type when pointer exits #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonikitoo
force-pushed
the
ozone-wayland-dev-issue-317
branch
from
eabf7a9
to
dd27c22
Compare
If user places the pointer/mouse on any end of a browser window, cursor type changes accordingly, to indicated a possible interactive resize operation. If the user crosses the browser window bounds through the same end, the mouse type stored in ui::CursorManager isn't reset. If pointer reenters the window through the same end, Aura tries to set the cursor type to the same as previously (to indicate it is over the same end). During the call chain, CursorManager::SetCursor compares the last Cursor stored and the new one and updates the cursor instance if they differ. In case of regular Chrome/x11 builds, the check passes because CursorData is set to the Cursor instance, and values always differ from the CursorData cached by CursorManager. In case of Linux/Ozone builds, CursorData is only set on Ozone side, so the call bail out and cursor is not updated. Patch fixes it by resetting the cursor type whenever pointer leaves the browser window. This ensures, when reentering from the same end, the comparison in CursorManager::SetCursor passes, and cursor gets updated. Issue Igalia#317
tonikitoo
force-pushed
the
ozone-wayland-dev-issue-317
branch
from
dd27c22
to
222a304
Compare
msisov
pushed a commit
that referenced
this pull request
Dec 23, 2018
The scheme check added at https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c caused some issues on WebView. This change deletes the check temporarily. TBR=yhirano@chromium.org (cherry picked from commit 14314b0) Bug: 898589 Change-Id: I6126b3b25f8700fc0547fa2c70b62bd183cc5e23 Reviewed-on: https://chromium-review.googlesource.com/c/1298828 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602736} Reviewed-on: https://chromium-review.googlesource.com/c/1299436 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#320} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
msisov
pushed a commit
that referenced
this pull request
Jan 31, 2019
According to metrics, 0.3% of forms have >100 fields (the current limit), increase the limit to 250 in order to cover all forms. Autofill throttling limits the number of queries/uploads are sent for a given form by a given user. Therefore, uploading huge forms wouldn't flood network. Bug: 857454 Change-Id: Ia92a3d6f2033159df121d8728a263c70ee7914f7 Reviewed-on: https://chromium-review.googlesource.com/c/1369772 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615523}(cherry picked from commit ba5fd2a) Reviewed-on: https://chromium-review.googlesource.com/c/1375114 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#320} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
msisov
pushed a commit
that referenced
this pull request
Mar 14, 2019
… mode - Adds any preconfigured shares that do not match an explicitly known mode to the dropdown. - If new policies are added to later milestones that are unknown in older versions of Chrome, the preconfigured shares will fallback to being added in the dropdown. This ensures that we can gracefully handle adding new enterprise policies in the future. TBR=baileyberro@chromium.org (cherry picked from commit ccc08e1) Bug: chromium:929322 Change-Id: I693ad6d102e0cfe3129ee349b86df84851038eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1456945 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#630444} Reviewed-on: https://chromium-review.googlesource.com/c/1461548 Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#320} Cr-Branched-From: e510299-refs/heads/master@{#625896}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user places the pointer/mouse on any end of a browser window, cursor
type changes accordingly, to indicated a possible interactive resize operation.
If the user crosses the browser window bounds through the same end, the mouse
type stored in ui::CursorManager isn't reset. If pointer reenters the
window through the same end, Aura tries to set the cursor type to the
same as previously (to indicate it is over the same end). During the
call chain, CursorManager::SetCursor compares the last Cursor stored
and the new one and updates the cursor instance if they differ.
In case of regular Chrome/x11 builds, the check passes because
CursorData is set to the Cursor instance, and values always differ
from the CursorData cached by CursorManager.
In case of Linux/Ozone builds, CursorData is only set on Ozone side,
so the call bail out and cursor is not updated.
Patch fixes it by resetting the cursor type whenever pointer leaves
the browser window. This ensures, when reentering from the same end, the
comparison in CursorManager::SetCursor passes, and cursor gets updated.
Issue #317