[#439] Append a hash to minified file names. #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enforce browsers to retrieve again the file when the hash changes, making sure users don't use old versions of the JS code. The minify script is changed in several ways, in addition to calculating and appending the hash to the file name: * To revert previous minification, we now use git reset --hard. It's dangerous but prevents the regexp logic from getting too wild. * We now loop through the php files for every js file, making the script much less efficient. Again, this is done to simplify regexp logic. * Explicitly delete source map files from previous minification, to prevent maps with different hashes to pile up.
anarute
approved these changes
May 3, 2022
|
Same as I, but I found an article about a solution that looked straightforward to implement and I gave it a try. It wasn't so easy and I got in trouble with regexps, but I think it works in the end. We need to be careful when deploying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enforce browsers to retrieve again the file when the hash changes, making sure users don't use old versions of the JS code.
The minify script is changed in several ways, in addition to calculating and appending the hash to the file name:
To revert previous minification, we now use git reset --hard. It's dangerous but prevents the regexp logic from getting too wild.
We now loop through the php files for every js file, making the script much less efficient. Again, this is done to simplify regexp logic.
Explicitly delete source map files from previous minification, to prevent maps with different hashes to pile up.
Fixes #439.