Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable leafrefs in ietf-alarms #1094

Merged
merged 1 commit into from Jun 13, 2018

Conversation

dpino
Copy link
Member

@dpino dpino commented Jun 13, 2018

When YANG leafref datatype was not supported, all leafrefs in
ietf-alarms were commented and used string as type. The patch undoes
that change, resetting ietf-alarms to its original state.

When YANG leafref datatype was not supported, all leafrefs in
ietf-alarms were commented and used string as type. The patch undoes
that change, resetting ietf-alarms to its original state.
@dpino
Copy link
Member Author

dpino commented Jun 13, 2018

To test it I informally run a lwaftr.conf that raises one alarm and query it with alarms get-state.

...
  alarm-list {                              
    alarm {                                 
      alarm-type-id arp-resolution;         
      alarm-type-qualifier '';              
      resource 32684;                       
      alarm-text "Make sure you can resolve external-interface.next-hop.ip address manually.  If it cannot be resolved, consider setting the MAC address of the next-hop directly.  To do it so, set external-interface.next-hop.mac to the value of the MAC address.";
      is-cleared false;                     
      last-changed 2018-06-13T13:55:49Z;    
      perceived-severity critical;          
      status-change {                       
        time 2018-06-13T13:55:49Z;          
        alarm-text "Make sure you can resolve external-interface.next-hop.ip address manually.  If it cannot be resolved, consider setting the MAC address of the next-hop directly.  To do it so, set external-interface.next-hop.mac to the value of the MAC address.";
        perceived-severity critical;        
      }                                     
      time-created 2018-06-13T13:55:49Z;    
    }                                       
    last-changed 2018-06-13T13:55:49Z;      
    number-of-alarms 1;                     
  }                                         
  summary {                                 
    alarm-summary {                         
      cleared 0;                            
      cleared-closed 0;                     
      cleared-not-closed 0;                 
      not-cleared-closed 0;                 
      not-cleared-not-closed 1;             
      total 1;                              
    }                                       
  }                                     

@dpino dpino merged commit 8907970 into Igalia:lwaftr Jun 13, 2018
@dpino dpino deleted the enable-leafrefs-ietf-alarms branch June 13, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants