Controllers disappear during video playback #1181
Labels
Comments
|
Video: trim.B5320DBA-D6D2-4F9D-8703-61192E807651.MOV |
felipeerias
changed the title
HollowMan6
added a commit
that referenced
this issue
Jan 19, 2024
Resolves #1181 User can exit the full screen and play the video afterwards, so we have to make sure we are still in full screen Signed-off-by: Songlin Jiang <sjiang@igalia.com>
felipeerias
added a commit
that referenced
this issue
Jan 23, 2024
This fixes a bug with video websites like https://www.ixigua.com/ The following sequence of steps: - enter fullscreen mode - leave fullscreen mode - play the video left the app in an unusable state because the controllers became hidden and the user was not able to get them to appear again. The cause was that when the page first enters fullscreen mode, `NavigationBarWidget.onFullScreen` added a listener to the window which would wait for the current video to become available and would then update the UI for fullscreen mode. That listener was not being removed when the page left fullscreen mode, so when the user played the video later on, the listener would get activated and would try to transition the UI to fullscreen mode. This was leaving the app in an inconsistent state so clicks on the background were being ignored (`onWorldClick`). The fix is to ensure that the window listener is removed when the page leavs fullscreen mode. Just in case, `onWorldClick` will make the controllers visible by default. Fixes #1181
felipeerias
added a commit
that referenced
this issue
Jan 23, 2024
This fixes a bug with video websites like https://www.ixigua.com/ The following sequence of steps: - enter fullscreen mode - leave fullscreen mode - play the video left the app in an unusable state because the controllers became hidden and the user was not able to get them to appear again. The cause was that when the page first enters fullscreen mode, `NavigationBarWidget.onFullScreen` added a listener to the window which would wait for the current video to become available and would then update the UI for fullscreen mode. That listener was not being removed when the page left fullscreen mode, so when the user played the video later on, the listener would get activated and would try to transition the UI to fullscreen mode. This was leaving the app in an inconsistent state so clicks on the background were being ignored (`onWorldClick`). The fix is to ensure that the window listener is removed when the page leavs fullscreen mode. Just in case, `onWorldClick` will make the controllers visible by default. Fixes #1181
felipeerias
added a commit
that referenced
this issue
Jan 23, 2024
This fixes a bug with video websites like https://www.ixigua.com/ The following sequence of steps: - enter fullscreen mode - leave fullscreen mode - play the video left the app in an unusable state because the controllers became hidden and the user was not able to get them to appear again. The cause was that when the page first enters fullscreen mode, `NavigationBarWidget.onFullScreen` added a listener to the window which would wait for the current video to become available and would then update the UI for fullscreen mode. That listener was not being removed when the page left fullscreen mode, so when the user played the video later on, the listener would get activated and would try to transition the UI to fullscreen mode. This was leaving the app in an inconsistent state so clicks on the background were being ignored (`onWorldClick`). The fix is to ensure that the window listener is removed when the page leavs fullscreen mode. Just in case, `onWorldClick` will make the controllers visible by default. Fixes #1181
|
I guess we can close this since #1198 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Configuration
Wolvic version: 1.5.2
Steps to Reproduce
Current Behavior
The controllers disappear. Any user actions (click, etc.) are ignored.
Context
This is the most reliable way to trigger the bug, but it might be happening on other websites as well.
The text was updated successfully, but these errors were encountered: