Controller's 3D models might not be loaded with multiple interaction profiles #1445
Assignees
Comments
svillar
added a commit
that referenced
this issue
Jun 12, 2024
Now that hand interaction profile is available for some devices it might happen that the user uses it at start time. That profile, as it's meant to be used for hand tracking, does not require any 3D model (the hand 3D model uses hand tracking joints that are not related to the hand interaction profile). This means that the callback of OnControllersReady() in BrowserWorld will not load any 3D model, and then DeviceDelegateOpenXR will uninstall the callback. Then if the user ever grabs a physical controller, the interaction profile will be updated (as we get notified by the runtime), but no 3D models would be ever loaded for those controllers as the callback is now null. In order to fix that, the callback for OnControllersReady now returns a boolean representing whether or not the 3D models where loaded. If it's true then we can uninstall the callback after completion. If it's false then we leave the callback ready for eventual interaction profile changes. Note that this do not support having multiple physical controllers for a single device, but that scenario is unlikely to happen. We have also moved the callback signature to a typedef, that is not really required but it's better for robustness and maintenance as it allows us to modify it in a single place. Fixes #1445
svillar
added a commit
that referenced
this issue
Jun 14, 2024
Now that hand interaction profile is available for some devices it might happen that the user uses it at start time. That profile, as it's meant to be used for hand tracking, does not require any 3D model (the hand 3D model uses hand tracking joints that are not related to the hand interaction profile). This means that the callback of OnControllersReady() in BrowserWorld will not load any 3D model, and then DeviceDelegateOpenXR will uninstall the callback. Then if the user ever grabs a physical controller, the interaction profile will be updated (as we get notified by the runtime), but no 3D models would be ever loaded for those controllers as the callback is now null. In order to fix that, the callback for OnControllersReady now returns a boolean representing whether or not the 3D models where loaded. If it's true then we can uninstall the callback after completion. If it's false then we leave the callback ready for eventual interaction profile changes. Note that this do not support having multiple physical controllers for a single device, but that scenario is unlikely to happen. We have also moved the callback signature to a typedef, that is not really required but it's better for robustness and maintenance as it allows us to modify it in a single place. Fixes #1445
svillar
added a commit
that referenced
this issue
Jun 18, 2024
Now that hand interaction profile is available for some devices it might happen that the user uses it at start time. That profile, as it's meant to be used for hand tracking, does not require any 3D model (the hand 3D model uses hand tracking joints that are not related to the hand interaction profile). This means that the callback of OnControllersReady() in BrowserWorld will not load any 3D model, and then DeviceDelegateOpenXR will uninstall the callback. Then if the user ever grabs a physical controller, the interaction profile will be updated (as we get notified by the runtime), but no 3D models would be ever loaded for those controllers as the callback is now null. In order to fix that, the callback for OnControllersReady now returns a boolean representing whether or not the 3D models where loaded. If it's true then we can uninstall the callback after completion. If it's false then we leave the callback ready for eventual interaction profile changes. Note that this do not support having multiple physical controllers for a single device, but that scenario is unlikely to happen. We have also moved the callback signature to a typedef, that is not really required but it's better for robustness and maintenance as it allows us to modify it in a single place. Fixes #1445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current code assumes that there is a perfect 1-to-1 match between interaction profiles (or mappings as in the code) and devices. That was true by the FxR time. However that assumption is no longer true since we added support for cross device interaction profiles like hand interaction.
The OpenXR backend code triggers the 3D model loading after verifying that there is an active mapping. That works for most of the cases. However it does break in the following scenario:
MaybeNotifyControllersReady()so no 3D model for the controllers would be loadedThe text was updated successfully, but these errors were encountered: