Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Privacy and Security] Add trusted Root CA option #489

Closed
worph opened this issue Feb 13, 2023 · 9 comments · Fixed by #1004
Closed

[Privacy and Security] Add trusted Root CA option #489

worph opened this issue Feb 13, 2023 · 9 comments · Fixed by #1004
Labels
enhancement New feature or request

Comments

@worph
Copy link

worph commented Feb 13, 2023

Is your feature request related to a problem? Please describe.
We would like a feature to add trusted Root CA in Wolvic.

Describe the solution you'd like
A menu in the settings where we can browse for a CRT file on the headset to be added to the root trusted certificate.
Something like the Privacy and Security panel in firefox. https://javorszky.co.uk/2019/11/06/get-firefox-to-trust-your-self-signed-certificates/#solve-the-self-signed-cert-thing

Describe alternatives you've considered
Rebuilding Wolvic ourself to add an exception to some domain.

Additional context
The aim is to have Wolvic work in corporate settings on an internal network.

@svillar svillar added the enhancement New feature or request label Feb 14, 2023
@Arkrixe
Copy link

Arkrixe commented Feb 15, 2023

Needed !

@svillar
Copy link
Member

svillar commented Feb 16, 2023

Here we're limited by what the GeckoView interface allows us to do. There is no current API in GeckoView to import individual root certificates.

However there is an open bug even with a proposed patch to add that API. We could consider adding that to the Gecko fork we're using for Wolvic.

But there is even another alternative which does not involve patching Gecko, and it's the preferred one from our POV if that works for you. As explained here we can instruct Gecko (with no API changes) to use the root certs from Android storage. If that works for you it's just a matter of enabling a configuration setting inside Wolvic and would be included in future releases.

@worph
Copy link
Author

worph commented Feb 17, 2023

Yes I think the best way to do this would be to use the certificate from the system unfortunately there is no way (to my knowledge) to add trusted certificate in the Quest 2 OS (which we would like to use).

Using the Gecko fork from bugzilla would solve this issue for our usecase on quest 2. That would be great.

@felipeerias
Copy link
Contributor

@worph I am having a look at the Gecko patch and my understanding is that it only supports adding a single root certificate. Would that be enough to cover your use case?

Can you foresee other scenarios where somebody might need to add more than one certificate?

@worph
Copy link
Author

worph commented Feb 17, 2023

For our usecase it would be enough since we only have to add the certificate for the internal corporate network and we only have one.

"Can you foresee other scenarios where somebody might need to add more than one certificate?" => I do not think so.

@jox
Copy link

jox commented Mar 22, 2023

Same here. Being able to add a custom certificate would be fantastic. Just one would be sufficient for us as well.

@jkumara
Copy link

jkumara commented Jul 18, 2023

This would be fantastic, being able to add even just one certificate would go a long way.

@HollowMan6 HollowMan6 self-assigned this Sep 13, 2023
@HollowMan6
Copy link
Collaborator

Unfortunately, looks like the issue at Mozilla Bugzilla closed as won't fix, and the patch proposed there didn't get merged https://phabricator.services.mozilla.com/D153882

So let's use the alternative API as explained here to get this issue resolved, which is to instruct Gecko to use the root certs from Android. Although there might be no way to add a trusted certificate in the Meta Quest 2 OS.

HollowMan6 added a commit that referenced this issue Sep 21, 2023
Resolve #489

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6 added a commit that referenced this issue Sep 21, 2023
Resolve #489

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
@HollowMan6 HollowMan6 removed their assignment Sep 21, 2023
@HollowMan6
Copy link
Collaborator

Investigated the Meta Quest 2 system for installing certificates. Looks like we are not able to install the certificate into the system at all. I tried to use the method here https://stackoverflow.com/a/75096266 but it keeps telling me it can't read the certificate although I believe I have inputted the correct path. Then I finally found the option to install the certificate while connecting to Eduroam, and I installed the certificate with the correct type (VPN and app user certificate), but still, I can't visit the websites using that certificate, so I think Meta Quest 2 may have disabled the user trusted Root certificate from working.

image
image

svillar pushed a commit that referenced this issue Sep 25, 2023
Resolve #489

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
felipeerias pushed a commit that referenced this issue Oct 16, 2023
Resolve #489

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
felipeerias pushed a commit that referenced this issue Oct 17, 2023
Resolve #489

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants