Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when the location service is not able to locate a provider #684

Closed
javifernandez opened this issue May 19, 2023 · 0 comments · Fixed by #794
Closed

Crash when the location service is not able to locate a provider #684

javifernandez opened this issue May 19, 2023 · 0 comments · Fixed by #794
Labels
good first issue Good for newcomers

Comments

@javifernandez
Copy link
Member

Configuration

Wolvic version: main branch (commit 91faf85)
Wolvic build ID: ---

Hardware: Lenovo A3
SO: Runtime 0.13.0

Steps to Reproduce

  1. Launch Wolvic

Current Behavior

The app doesn't stat

Expected Behavior

The app is launched successfully

Possible Solution

There are probably better ways to handle this exception, especially coming by the location service activation, which is not essential for the app's functionality.

Context

It seems that the device is not able to get connection with the location services and the fetch operation timesout. Our implementation of the fetch operation in GeckoViewFetchClient.kt file rasies a SocketTimeoutException in this scenation, which eventually causes the app to hang or being aborted by the system.

Error Logs and Stack Traces

com.igalia.wolvic.dev D Could not fetch region from location service
java.net.SocketTimeoutException
at com.igalia.wolvic.browser.api.impl.GeckoViewFetchClient.fetch(GeckoViewFetchClient.kt:57)
at mozilla.components.service.location.MozillaLocationServiceKt.fetchRegion(MozillaLocationService.kt:141)
at mozilla.components.service.location.MozillaLocationServiceKt.access$fetchRegion(MozillaLocationService.kt:1)
at mozilla.components.service.location.MozillaLocationService$fetchRegion$2.invokeSuspend(MozillaLocationService.kt:73)
at mozilla.components.service.location.MozillaLocationService$fetchRegion$2.invoke(Unknown Source:10)
at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:91)
at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(Builders.common.kt:165)
at kotlinx.coroutines.BuildersKt.withContext(Unknown Source:1)
at mozilla.components.service.location.MozillaLocationService.fetchRegion(MozillaLocationService.kt:68)
at com.igalia.wolvic.geolocation.GeolocationWrapper$update$1.invokeSuspend(GeolocationWrapper.kt:24)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

@svillar svillar changed the title Wolvic doesn't launch Crash if location services is not able to locate a provider May 19, 2023
@svillar svillar changed the title Crash if location services is not able to locate a provider Crash when the location service is not able to locate a provider May 19, 2023
@svillar svillar added the good first issue Good for newcomers label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants